fix: Don't show join default channels option for edit user form

.changeset/real-bobcats-train.md

@@ -0,0 +1,6 @@
+---
+'@rocket.chat/rest-typings': patch
+'@rocket.chat/meteor': patch
+---
+
+Don't show Join default channels option on edit user form and stop accepting this param on API

apps/meteor/client/views/admin/users/AdminUserForm.tsx

@@ -52,10 +52,12 @@ const getInitialValue = ({
 	data,
 	defaultUserRoles,
 	isSmtpEnabled,
+	isEditingExistingUser,
 }: {
 	data?: Serialized<IUser>;
 	defaultUserRoles?: IUser['roles'];
 	isSmtpEnabled?: boolean;
+	isEditingExistingUser?: boolean;
 }) => ({
 	roles: data?.roles ?? defaultUserRoles,
 	name: data?.name ?? '',
@@ -69,7 +71,7 @@ const getInitialValue = ({
 	requirePasswordChange: data?.requirePasswordChange || false,
 	customFields: data?.customFields ?? {},
 	statusText: data?.statusText ?? '',
-	joinDefaultChannels: true,
+	...(!isEditingExistingUser && { joinDefaultChannels: true }),
 	sendWelcomeEmail: isSmtpEnabled,
 	avatar: '' as AvatarObject,
 });
@@ -97,14 +99,16 @@ const UserForm = ({ userData, onReload, ...props }: AdminUserFormProps) => {
 
 	const goToUser = useCallback((id) => router.navigate(`/admin/users/info/${id}`), [router]);
 
+	const isEditingExistingUser = Boolean(userData?._id);
+
 	const {
 		control,
 		watch,
 		handleSubmit,
 		reset,
 		formState: { errors, isDirty },
 	} = useForm({
-		defaultValues: getInitialValue({ data: userData, defaultUserRoles, isSmtpEnabled }),
+		defaultValues: getInitialValue({ data: userData, defaultUserRoles, isSmtpEnabled, isEditingExistingUser }),
 		mode: 'onBlur',
 	});
 
@@ -166,7 +170,7 @@ const UserForm = ({ userData, onReload, ...props }: AdminUserFormProps) => {
 		<>
 			<ContextualbarScrollableContent {...props}>
 				<FieldGroup>
-					{userData?._id && (
+					{isEditingExistingUser && (
 						<Field>
 							<Controller
 								name='avatar'
@@ -346,7 +350,7 @@ const UserForm = ({ userData, onReload, ...props }: AdminUserFormProps) => {
 								<Controller
 									control={control}
 									name='password'
-									rules={{ required: !userData?._id && t('The_field_is_required', t('Password')) }}
+									rules={{ required: !isEditingExistingUser && t('The_field_is_required', t('Password')) }}
 									render={({ field }) => (
 										<PasswordInput
 											{...field}
@@ -434,18 +438,20 @@ const UserForm = ({ userData, onReload, ...props }: AdminUserFormProps) => {
 						</FieldRow>
 						{errors?.roles && <FieldError>{errors.roles.message}</FieldError>}
 					</Field>
-					<Field>
-						<FieldRow>
-							<FieldLabel htmlFor={joinDefaultChannelsId}>{t('Join_default_channels')}</FieldLabel>
-							<Controller
-								control={control}
-								name='joinDefaultChannels'
-								render={({ field: { ref, onChange, value } }) => (
-									<ToggleSwitch id={joinDefaultChannelsId} ref={ref} onChange={onChange} checked={value} />
-								)}
-							/>
-						</FieldRow>
-					</Field>
+					{!isEditingExistingUser && (
+						<Field>
+							<FieldRow>
+								<FieldLabel htmlFor={joinDefaultChannelsId}>{t('Join_default_channels')}</FieldLabel>
+								<Controller
+									control={control}
+									name='joinDefaultChannels'
+									render={({ field: { ref, onChange, value } }) => (
+										<ToggleSwitch id={joinDefaultChannelsId} ref={ref} onChange={onChange} checked={value} />
+									)}
+								/>
+							</FieldRow>
+						</Field>
+					)}
 					<Field>
 						<FieldRow>
 							<FieldLabel htmlFor={sendWelcomeEmailId}>{t('Send_welcome_email')}</FieldLabel>

packages/rest-typings/src/v1/users/UsersUpdateParamsPOST.ts

@@ -16,7 +16,6 @@ export type UsersUpdateParamsPOST = {
 		nickname?: string;
 		statusText?: string;
 		roles?: string[];
-		joinDefaultChannels?: boolean;
 		requirePasswordChange?: boolean;
 		setRandomPassword?: boolean;
 		sendWelcomeEmail?: boolean;
@@ -78,10 +77,6 @@ const UsersUpdateParamsPostSchema = {
 					},
 					nullable: true,
 				},
-				joinDefaultChannels: {
-					type: 'boolean',
-					nullable: true,
-				},
 				requirePasswordChange: {
 					type: 'boolean',
 					nullable: true,