-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Limit of members that can be added using the autojoin feature in a team's channel to the value of the API_Users_Limit setting #31859
feat: Limit of members that can be added using the autojoin feature in a team's channel to the value of the API_Users_Limit setting #31859
Conversation
🦋 Changeset detectedLatest commit: 4cbf36b The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR is a copy of #31423 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31859 +/- ##
===========================================
- Coverage 56.42% 56.41% -0.02%
===========================================
Files 2445 2450 +5
Lines 53932 54017 +85
Branches 11118 11134 +16
===========================================
+ Hits 30432 30472 +40
- Misses 20849 20885 +36
- Partials 2651 2660 +9
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add tests to cover this feature?
We can use a small number for the setting to avoid creating too many users.
The ideal would be to test every case, with more and less members than the accepted, etc.
We can also add some UI tests to make sure the error is being displayed if the limit was exceeded.
…f-auto-join-members
Co-authored-by: Matheus Barbosa Silva <[email protected]>
Co-authored-by: Matheus Barbosa Silva <[email protected]>
apps/meteor/client/views/teams/contextualBar/channels/hooks/useToggleAutoJoin.tsx
Show resolved
Hide resolved
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
apps/meteor/client/views/teams/contextualBar/channels/hooks/useToggleAutoJoin.tsx
Show resolved
Hide resolved
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
Proposed changes (including videos or screenshots)
There existed an implicit limit of 50 members that would be included whenever a a channel with auto join was created inside a team, this task ties the limit to the API_Users_Limit setting, so it is configurable.
Issue(s)
Steps to test or reproduce
This task requires a team with over 1000 members, so all of these members should be created and associated with the team
All the members should've been added correctly
Now the new user should not have been added since there is a hard limit of 1000 members
Further comments
SUP-34
This PR is a copy of #31423
I created this one, because the other one was created from a fork which was causing a few problems such as weird conflicts