Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redesign Save E2EE password modal #31865

Merged
merged 24 commits into from
Apr 19, 2024
Merged

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Feb 29, 2024

Proposed changes (including videos or screenshots)

Issue(s)

  1. Reset E2EE keys, user will be logged out, log back in.
  2. The save e2ee password banner would appear on top, click it.
  3. New redesigned e2ee modal appears.

Steps to test or reproduce

Further comments

E2EE-18

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: 138c633

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 52.23%. Comparing base (2c85072) to head (138c633).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31865      +/-   ##
===========================================
- Coverage    53.69%   52.23%   -1.47%     
===========================================
  Files         2298     2167     -131     
  Lines        50509    48466    -2043     
  Branches     10343     9840     -503     
===========================================
- Hits         27121    25316    -1805     
+ Misses       20981    20849     -132     
+ Partials      2407     2301     -106     
Flag Coverage Δ
e2e 48.64% <25.00%> (-3.00%) ⬇️
unit 75.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review March 1, 2024 12:28
@yash-rajpal yash-rajpal requested a review from a team as a code owner March 1, 2024 12:28
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider this a feat instead of a chore.

@yash-rajpal yash-rajpal changed the title chore: Redesign Save E2EE password modal feat: Redesign Save E2EE password modal Mar 11, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The annotation is not breaking the line
Screenshot 2024-03-13 at 11 25 32

Also, would be nice to have feedback that the code was copied, as we used to have before (changing the text and disabling the button for some time)

@yash-rajpal
Copy link
Member Author

Disable copy button will work after we merge and release fuselage-1338

dougfabris
dougfabris previously approved these changes Apr 2, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

MarcosSpessatto
MarcosSpessatto previously approved these changes Apr 4, 2024
dougfabris
dougfabris previously approved these changes Apr 5, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Apr 16, 2024
@milton-rucks milton-rucks added this to the 6.8 milestone Apr 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 19, 2024
@kodiakhq kodiakhq bot merged commit 15bc998 into develop Apr 19, 2024
42 of 43 checks passed
@kodiakhq kodiakhq bot deleted the e2e-save-modal-redesign branch April 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants