-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Redesign Save E2EE password modal #31865
Conversation
🦋 Changeset detectedLatest commit: 138c633 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31865 +/- ##
===========================================
- Coverage 53.69% 52.23% -1.47%
===========================================
Files 2298 2167 -131
Lines 50509 48466 -2043
Branches 10343 9840 -503
===========================================
- Hits 27121 25316 -1805
+ Misses 20981 20849 -132
+ Partials 2407 2301 -106
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider this a feat instead of a chore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable copy button will work after we merge and release fuselage-1338 |
Looks like this PR is ready to merge! 🎉 |
5ff2123
4410adb
to
5ff2123
Compare
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
E2EE-18