-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New users page active tab #32024
Conversation
🦋 Changeset detectedLatest commit: 79b0324 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32024 +/- ##
===========================================
- Coverage 55.54% 54.39% -1.15%
===========================================
Files 2633 2554 -79
Lines 57197 56026 -1171
Branches 11848 11623 -225
===========================================
- Hits 31768 30474 -1294
- Misses 22743 22941 +198
+ Partials 2686 2611 -75
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks like this PR is ready to merge! 🎉 |
5e31c7a
to
c6e5b7f
Compare
Added a new "active" tab to the users page table, this tab lists the users that haved logged in for the first time and are active. Also, implemented a roles filtering component, improved the MultiSelectCustom and created the necessary new translation keys.
Changed the implementation of the new users table filters from a fully custom "Box based" code to a standardized use of the FilterByText component with children. Also improved the positioning and styling of the MultiSelectCustom by properly implementing the useOutsideClick and usePosition custom hooks together with reusing the fuselage button and input styles in the anchor of the component.
66844ff
to
d315d45
Compare
Proposed changes (including videos or screenshots)
Implemented a new "active" tab to the users page table, this tab lists the users that haved logged in for the first time and are active. Also, implemented a roles filtering component, improved the MultiSelectCustom and created the necessary new translation keys.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments
Blocked by: #31987 and #32470
Related to: #30236
Old Jira task: WM-51
New Jira task for Conn: CONN-273