Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: UserCard overlapping Modal #32067

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 25, 2024

Proposed changes (including videos or screenshots)

Clipboard - June 19, 2024 5_19 PM

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: 3e25ebe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.34%. Comparing base (2fabc1c) to head (3e25ebe).
Report is 2 commits behind head on release-6.7.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.7.0   #32067      +/-   ##
=================================================
- Coverage          54.74%   54.34%   -0.41%     
=================================================
  Files               2299     2252      -47     
  Lines              50739    49884     -855     
  Branches           10380    10146     -234     
=================================================
- Hits               27778    27108     -670     
+ Misses             20465    20316     -149     
+ Partials            2496     2460      -36     
Flag Coverage Δ
e2e 52.95% <ø> (-0.78%) ⬇️
e2e-api 40.12% <ø> (-0.01%) ⬇️
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris changed the base branch from develop to release-6.7.0 March 26, 2024 14:30
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 26, 2024
@dougfabris dougfabris added this to the 6.7 milestone Mar 26, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 26, 2024
@dougfabris dougfabris marked this pull request as ready for review March 26, 2024 17:11
@dougfabris dougfabris requested review from a team as code owners March 26, 2024 17:12
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 28, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 28, 2024
@ggazzo ggazzo merged commit 0b1a360 into release-6.7.0 Mar 28, 2024
45 checks passed
@ggazzo ggazzo deleted the reg/cardOverlapping branch March 28, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants