fix: CSP error right after setInlineScriptsAllowed
#32108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32108 +/- ##
===========================================
- Coverage 54.70% 54.27% -0.44%
===========================================
Files 2298 2255 -43
Lines 50765 49959 -806
Branches 10394 10167 -227
===========================================
- Hits 27770 27114 -656
+ Misses 20493 20374 -119
+ Partials 2502 2471 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
fix/csp-race-condition
branch
from
c3de1e7
to
724599c
Compare
ggazzo
force-pushed
the
fix/csp-race-condition
branch
from
724599c
to
3b9c1b4
Compare
ggazzo
changed the title
setInlineScriptsAllowedCSP error right after setInlineScriptsAllowed
sampaiodiego
approved these changes
Apr 2, 2024
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* develop: (71 commits) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108) chore: Create/Edit room consistency (#31960) chore: Remove references to EE code from the app events (#31926) test(Livechat): Clean up after registerGuest() test (#32092) test: make presence api tests fully independent (#31782) test: make roles fully independent (#31783) chore: bump version to 7.0.0-develop test: make login api tests fully independent (#31786) fix!: api login should not suggest which credential is wrong (#32086) ...
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* origin: refactor: `TeamsChannels` to typescript (#32109) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
|
Looks like this PR is not ready to merge, because of the following issues:
|
dionisio-bot
bot
added
stat: QA assured
|
Looks like this PR is not ready to merge, because of the following issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
setInlineScriptsAllowedis an asynchronous function, calling it and forgetting generally works, however in some cases of intensive CPU use, the next requests may receive invalid contentIn real life it happens very rarely, but it happens a lot 🤣 (CI tasks)
it fixes flaky tests like:
1) omnichannel/omnichannel-livechat-department.spec.ts:69:6 › OC - Livechat - Department Flow › OC - Livechat - Chat with Departmentwhich is a test which the previous suite changed the valueIssue(s)
Steps to test or reproduce
Further comments