-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change cloud timeouts #32139
chore: change cloud timeouts #32139
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32139 +/- ##
===========================================
- Coverage 55.42% 55.38% -0.05%
===========================================
Files 2328 2325 -3
Lines 51371 51333 -38
Branches 10513 10507 -6
===========================================
- Hits 28473 28430 -43
- Misses 20385 20395 +10
+ Partials 2513 2508 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me :p
Proposed changes (including videos or screenshots)
Currently all calls to cloud.rocket.chat from Rocket.Chat in the sync process have a 3s timeout. We need to bump to 5s to give us a bit of wiggle room. If we don’t respond fast enough the sync fails. While we keep working on making our response faster we need Rocket.Chat to be a bit more tolerant
Issue(s)
Steps to test or reproduce
Further comments
CONN-109