Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change cloud timeouts #32139

Merged
merged 3 commits into from
Apr 23, 2024
Merged

chore: change cloud timeouts #32139

merged 3 commits into from
Apr 23, 2024

Conversation

heitortanoue
Copy link
Contributor

Proposed changes (including videos or screenshots)

Currently all calls to cloud.rocket.chat from Rocket.Chat in the sync process have a 3s timeout. We need to bump to 5s to give us a bit of wiggle room. If we don’t respond fast enough the sync fails. While we keep working on making our response faster we need Rocket.Chat to be a bit more tolerant

Issue(s)

Steps to test or reproduce

Further comments

CONN-109

Copy link
Contributor

dionisio-bot bot commented Apr 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 5, 2024

⚠️ No Changeset found

Latest commit: 4430a27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.38%. Comparing base (d38e112) to head (4430a27).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32139      +/-   ##
===========================================
- Coverage    55.42%   55.38%   -0.05%     
===========================================
  Files         2328     2325       -3     
  Lines        51371    51333      -38     
  Branches     10513    10507       -6     
===========================================
- Hits         28473    28430      -43     
- Misses       20385    20395      +10     
+ Partials      2513     2508       -5     
Flag Coverage Δ
e2e 54.77% <ø> (-0.07%) ⬇️
unit 74.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@Gustrb Gustrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :p

@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Apr 22, 2024
@ggazzo ggazzo added this to the 6.8 milestone Apr 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 23, 2024
@kodiakhq kodiakhq bot merged commit 1e772e4 into develop Apr 23, 2024
39 of 40 checks passed
@kodiakhq kodiakhq bot deleted the chore/cloud-timeout branch April 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants