fix: Custom OAuth roles are not correctly synced on user creation #32157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 18574f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32157 +/- ##
===========================================
+ Coverage 52.78% 55.08% +2.29%
===========================================
Files 2187 2306 +119
Lines 48967 50942 +1975
Branches 9997 10423 +426
===========================================
+ Hits 25849 28059 +2210
+ Misses 20800 20368 -432
- Partials 2318 2515 +197
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Bug was introduced by #27000
We need to take some time to add an OAuth service container to our tests so that we can write tests for those fixes.
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Configure a custom OAuth service with "Merge Roles from SSO" enabled and add some roles to sync. Use the custom OAuth service to login for the first time with a user that has any of the roles to sync assigned to them.
Current behavior: the roles are only assigned on their second login.
Expected behavior: the user should have their roles synced since the first login, on user creation.
Further comments
SUP-544