fix: Language priority order not respected when changing server setting #32170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bd58283 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32170 +/- ##
===========================================
+ Coverage 53.68% 55.39% +1.70%
===========================================
Files 2298 2317 +19
Lines 50518 51057 +539
Branches 10344 10458 +114
===========================================
+ Hits 27123 28283 +1160
+ Misses 20959 20261 -698
- Partials 2436 2513 +77
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Apr 11, 2024
MarcosSpessatto
approved these changes
Apr 18, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
csuadev
approved these changes
Apr 19, 2024
Merged
|
/backport 6.6.8 |
1 similar comment
|
/backport 6.6.8 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
|
/backport 6.7.3 |
dionisio-bot bot
pushed a commit
that referenced
this pull request
May 15, 2024
…ng (#32170) Co-authored-by: Douglas Fabris <[email protected]>
|
Pull request #32438 added to Project: "Patch 6.7.3" |
gabriellsh
added a commit
that referenced
this pull request
May 15, 2024
…ng (#32170) Co-authored-by: Douglas Fabris <[email protected]>
|
/backport 6.6.8 |
|
Pull request #32443 added to Project: "Patch 6.6.8" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Stop forcing language switch when changing setting. Priority should be:
User Preference > Browser Language > Server Language
In most cases Server language is just a fallback, and that will mostly happen in Desktop browser. If the user has not set a language in his preferences, notifications will respect the server's setting.
Issue(s)
SUP-493
Closes #32008
Steps to test or reproduce
Set a language in the user preferences
Go to admin > General > Language and change to another one
The language will switch to the one set on the setting instead of keeping the user preference.
Further comments