fix: UserDataFiles store uploads not proxied through server because of missing setting
#32182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 214b0e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32182 +/- ##
===========================================
- Coverage 55.51% 55.50% -0.01%
===========================================
Files 2371 2371
Lines 52060 52060
Branches 10650 10650
===========================================
- Hits 28901 28896 -5
- Misses 20626 20629 +3
- Partials 2533 2535 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
approved these changes
Apr 15, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
KevLehman
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rocketchat.atlassian.net/browse/SUP-521
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Problem with feature was caused because we're dynamically fetching the settings to decide if an store files should be proxied or not. The setting
Proxy_UserDataFilesdidn't exist, so when looking for this configuration it returned undefined and served assumed it asfalse.We now have the right setting.