fix: Omnichannel Jobs running every 5 seconds #32186
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 29dac58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32186 +/- ##
===========================================
+ Coverage 48.45% 54.61% +6.16%
===========================================
Files 1980 2289 +309
Lines 45294 50662 +5368
Branches 9153 10376 +1223
===========================================
+ Hits 21948 27670 +5722
+ Misses 21347 20512 -835
- Partials 1999 2480 +481
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Since we are skipping the test covering this, we will create unit tests to cover the whole class in a subsequent PR. |
There was a problem hiding this comment.
There is no way this could be a patch release, There is no problem being solved here, at most we are masking something worse. I don't believe we should release this as a fix.
Furthermore, the title points out to something different.
Skipping a test is not ideal, you could make this modifiable via an envvar
|
Problem being solved is that the default timing for OM jobs is 5 secs, while the default timer for any other Agenda job (via @rocket.chat/cron) is 1 minute. These items were left when refactoring from old jobs to /cron package. While I'd agree there's no "problem" being solved, the sole fact these jobs are going to the db every 5s (which also caused problems in the past when we first migrated to /cron) is problematic by itself. What title would you suggest? Title says we're increasing agenda time, maybe that part is not clear but what we're actually doing is increasing the agenda processing time. About the test, yeah, skipping is not ideal, but since this is targetted for an older version, we decided to not to add more stuff in here and just skip for now. Idea is to make these jobs configurable in the future, just not now. wdyt? |
|
I didn't understand the part about targeting an old version, as it is pointing to develop about the title, maybe something like fix: Omnichannel Jobs running every 5 seconds |
KevLehman
changed the title
agenda time in Omnichannel EE jobs to 1 minute
|
All right, updated PR title. I actually didn't notice I put this one as a chore. Fixed now. The part about and old version is from a customer that's getting bombed by this. When we first moved to |
scuciatto
added
the
stat: QA assured
KevLehman
added
the
stat: ready to merge
|
/patch |
|
Pull request #32253 added to Project: "Patch 6.7.1" |
https://rocketchat.atlassian.net/browse/CORE-259
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This is to reduce the frequency of these actions. These 3 schedulers were left behind when we moved away from synced-cron to our own cron package. Other task will be created to move these schedulers to use it in the future.