Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fingerprint auto accepted still asks for admin confirmation #32202

Merged
merged 3 commits into from
Apr 13, 2024
Merged

fix: fingerprint auto accepted still asks for admin confirmation #32202

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f963325
fix: fingerprint auto accepted still asks for admin confirmation
debdutdeb Apr 13, 2024
4555fcc
chore: add changeset
debdutdeb Apr 13, 2024
f275173
Update .changeset/shaggy-yaks-train.md
debdutdeb Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-yaks-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixed an issue where Rocket.Chat would ask admins to confirm fingerprint change (new workspace vs configuration update), even with `AUTO_ACCEPT_FINGERPRINT` environment variable set to `"true"`.
debdutdeb marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions apps/meteor/server/settings/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const verifyFingerPrint = async function () {
if (process.env.AUTO_ACCEPT_FINGERPRINT === 'true') {
logger.info('Updating fingerprint as AUTO_ACCEPT_FINGERPRINT is true', fingerprint);
await updateFingerprint(fingerprint, true);
return;
}

logger.warn('Updating fingerprint as pending for admin verification', fingerprint);
Expand Down
Loading