Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Unit tests for AutoCloseOnHold scheduler #32213

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Apr 15, 2024

https://rocketchat.atlassian.net/browse/CORE-262

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Unit tests for AutoCloseOnHold scheduler.

This installs chai-datetime package to assert the when parameters sent to the scheduler are close to the time we want it to be.

Copy link
Contributor

dionisio-bot bot commented Apr 15, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: 216b047

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (9cc8e3d) to head (216b047).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32213      +/-   ##
===========================================
- Coverage    55.44%   53.45%   -2.00%     
===========================================
  Files         2328     2236      -92     
  Lines        51371    49977    -1394     
  Branches     10513    10177     -336     
===========================================
- Hits         28483    26714    -1769     
- Misses       20377    20872     +495     
+ Partials      2511     2391     -120     
Flag Coverage Δ
e2e 50.75% <ø> (-4.12%) ⬇️
unit 75.37% <100.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review April 15, 2024 17:51
@KevLehman KevLehman requested a review from a team as a code owner April 15, 2024 17:51
@KevLehman KevLehman added this to the 6.8 milestone Apr 15, 2024
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Apr 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 15, 2024
@kodiakhq kodiakhq bot merged commit 4c45a73 into develop Apr 23, 2024
38 of 41 checks passed
@kodiakhq kodiakhq bot deleted the test/autocloseonhold-sch branch April 23, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants