Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Client check AutoTranslate_Enabled setting before a server endpoint call #32221

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Apr 16, 2024

Proposed changes (including videos or screenshots)

Check in client first to avoid the thrown by server:

image

Issue(s)

Steps to test or reproduce

Further comments

CORE-269

Copy link
Contributor

dionisio-bot bot commented Apr 16, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 850ee6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tiagoevanp tiagoevanp requested a review from a team April 16, 2024 12:47
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.28%. Comparing base (6b053ae) to head (850ee6c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32221      +/-   ##
===========================================
- Coverage    55.33%   55.28%   -0.05%     
===========================================
  Files         2319     2318       -1     
  Lines        51203    51177      -26     
  Branches     10477    10472       -5     
===========================================
- Hits         28332    28295      -37     
+ Misses       20387    20364      -23     
- Partials      2484     2518      +34     
Flag Coverage Δ
e2e 54.65% <0.00%> (-0.09%) ⬇️
unit 74.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp changed the title chore: Check AutoTranslate_Enabled before the endpoint call chore: Client check AutoTranslate_Enabled setting before a server endpoint call Apr 16, 2024
@tiagoevanp tiagoevanp added this to the 6.8 milestone Apr 16, 2024
@tiagoevanp tiagoevanp changed the title chore: Client check AutoTranslate_Enabled setting before a server endpoint call fix: Client check AutoTranslate_Enabled setting before a server endpoint call Apr 16, 2024
.changeset/strange-comics-camp.md Outdated Show resolved Hide resolved
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
@scuciatto scuciatto removed this from the 6.8 milestone Apr 19, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougfabris dougfabris added this to the 6.8 milestone Apr 19, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Apr 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 19, 2024
@kodiakhq kodiakhq bot merged commit 1b390c7 into develop Apr 19, 2024
43 checks passed
@kodiakhq kodiakhq bot deleted the chore/check_autotranslate_enable branch April 19, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants