Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Last threads list item doesn't display completely #32248

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 18, 2024

Proposed changes (including videos or screenshots)

Fixes an issue where the last threads list item wasn't displaying properly

before

after

Issue(s)

Steps to test or reproduce

Further comments

CORE-291

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: e3cedc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.38%. Comparing base (8b0986d) to head (e3cedc8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32248      +/-   ##
===========================================
+ Coverage    55.30%   55.38%   +0.07%     
===========================================
  Files         2319     2322       +3     
  Lines        51206    51241      +35     
  Branches     10475    10482       +7     
===========================================
+ Hits         28322    28379      +57     
+ Misses       20369    20351      -18     
+ Partials      2515     2511       -4     
Flag Coverage Δ
e2e 54.86% <ø> (+0.13%) ⬆️
unit 74.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.8 milestone Apr 18, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris marked this pull request as ready for review April 18, 2024 22:58
@dougfabris dougfabris requested a review from a team as a code owner April 18, 2024 22:58
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Apr 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 19, 2024
@kodiakhq kodiakhq bot merged commit d134a4d into develop Apr 19, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the fix/threadlistView branch April 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants