Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fingerprint auto accepted still asks for admin confirmation #32254

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Apr 18, 2024

Backport of #32202

@debdutdeb

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner April 18, 2024 20:40
Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: a6b2b40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 6.7 milestone Apr 18, 2024
Copy link
Contributor Author

dionisio-bot bot commented Apr 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (f717f34) to head (a6b2b40).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.7.1   #32254      +/-   ##
=================================================
+ Coverage          54.79%   54.80%   +0.01%     
=================================================
  Files               2303     2303              
  Lines              50839    50839              
  Branches           10389    10389              
=================================================
+ Hits               27856    27862       +6     
+ Misses             20492    20487       -5     
+ Partials            2491     2490       -1     
Flag Coverage Δ
e2e 53.86% <ø> (+0.01%) ⬆️
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
Copy link
Member

ggazzo commented Apr 19, 2024

/rebase

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 19, 2024
@kodiakhq kodiakhq bot merged commit f02012b into release-6.7.1 Apr 19, 2024
43 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.7.1-32202 branch April 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants