Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message): Support Message Custom Fields on upload API #32272

Merged
merged 9 commits into from
Apr 20, 2024

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Apr 19, 2024

Proposed changes (including videos or screenshots)

Support customFields property via FormData field named customFields using a JSON value to represent the object:

request.post(api(`rooms.upload/${testChannel._id}`))
    .field('customFields', JSON.stringify({
        field1: 'value1'
    }))

Issue(s)

CORE-274

Steps to test or reproduce

Further comments

@rodrigok rodrigok added this to the 6.8 milestone Apr 19, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: a2e7ad5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rodrigok rodrigok changed the title fix(message): Missing Message Custom Field on upload API feat(message): Support Message Custom Fields on upload API Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.35%. Comparing base (845fd64) to head (a2e7ad5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32272      +/-   ##
===========================================
- Coverage    55.44%   55.35%   -0.09%     
===========================================
  Files         2329     2323       -6     
  Lines        51349    51291      -58     
  Branches     10503    10493      -10     
===========================================
- Hits         28471    28394      -77     
+ Misses       20396    20389       -7     
- Partials      2482     2508      +26     
Flag Coverage Δ
e2e 54.73% <ø> (-0.17%) ⬇️
unit 74.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok marked this pull request as ready for review April 19, 2024 21:23
@rodrigok rodrigok requested a review from a team as a code owner April 19, 2024 21:23
@rodrigok rodrigok added the stat: QA assured Means it has been tested and approved by a company insider label Apr 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 19, 2024
@rodrigok rodrigok requested a review from a team as a code owner April 20, 2024 00:00
ggazzo
ggazzo previously approved these changes Apr 20, 2024
ggazzo
ggazzo previously approved these changes Apr 20, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 20, 2024
Copy link
Contributor

kodiakhq bot commented Apr 20, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@rodrigok rodrigok added the stat: ready to merge PR tested and approved waiting for merge label Apr 20, 2024
@kodiakhq kodiakhq bot merged commit 3925d43 into develop Apr 20, 2024
42 of 43 checks passed
@kodiakhq kodiakhq bot deleted the fix/missing-customfields-on-upload-api branch April 20, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants