Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add alpine indication to test jobs that use it #32286

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

d-gubert
Copy link
Member

Proposed changes (including videos or screenshots)

Add an Alpine indicator to test jobs that use it

Issue(s)

Steps to test or reproduce

Further comments

@d-gubert d-gubert requested a review from a team as a code owner April 22, 2024 17:26
Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: f4fe592

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.84%. Comparing base (d79ddf1) to head (f4fe592).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32286      +/-   ##
===========================================
- Coverage    55.45%   54.84%   -0.61%     
===========================================
  Files         2330     2277      -53     
  Lines        51375    50419     -956     
  Branches     10514    10272     -242     
===========================================
- Hits         28488    27654     -834     
+ Misses       20375    20289      -86     
+ Partials      2512     2476      -36     
Flag Coverage Δ
e2e 53.73% <ø> (-1.15%) ⬇️
unit 74.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I guess we can get rid of the false 😬

Copy link
Contributor

dionisio-bot bot commented Apr 22, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@d-gubert
Copy link
Member Author

image I guess we can get rid of the `false` 😬

Definitely, this should be a draft PR anyway 😂

@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Apr 23, 2024
@d-gubert d-gubert added this to the 6.8 milestone Apr 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 23, 2024
@kodiakhq kodiakhq bot merged commit 9cc8e3d into develop Apr 23, 2024
40 of 41 checks passed
@kodiakhq kodiakhq bot deleted the chore/improve-ci-job-name branch April 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants