Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returning user status text for apps #32314

Merged
merged 5 commits into from
May 10, 2024

Conversation

AllanPazRibeiro
Copy link
Contributor

@AllanPazRibeiro AllanPazRibeiro commented Apr 25, 2024

Proposed changes (including videos or screenshots)

This PR adds the user status text in the user bridge response.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-249

Steps to test or reproduce

Further comments

@AllanPazRibeiro AllanPazRibeiro self-assigned this Apr 25, 2024
Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: d06681c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Apr 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@AllanPazRibeiro AllanPazRibeiro marked this pull request as ready for review April 25, 2024 17:31
@AllanPazRibeiro AllanPazRibeiro requested a review from a team as a code owner April 25, 2024 17:31
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.61%. Comparing base (3433f48) to head (d06681c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32314      +/-   ##
===========================================
+ Coverage    55.58%   55.61%   +0.03%     
===========================================
  Files         2405     2405              
  Lines        52929    52929              
  Branches     10872    10872              
===========================================
+ Hits         29421    29438      +17     
+ Misses       20907    20894      -13     
+ Partials      2601     2597       -4     
Flag Coverage Δ
e2e 54.96% <ø> (+0.02%) ⬆️
unit 73.40% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AllanPazRibeiro AllanPazRibeiro force-pushed the fix/CORE-249/returning-user-status-text-to-apps branch from 6310a53 to b5d3eeb Compare April 25, 2024 17:39
KevLehman
KevLehman previously approved these changes Apr 25, 2024
@KevLehman KevLehman dismissed their stale review April 25, 2024 17:56

we can try to add tests :)

Copy link
Contributor Author

@AllanPazRibeiro AllanPazRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add tests in a different PR

@AllanPazRibeiro AllanPazRibeiro added this to the 6.9 milestone Apr 26, 2024
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's not lose sight of those tests though :)

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label May 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 10, 2024
@kodiakhq kodiakhq bot merged commit bf4b4cc into develop May 10, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the fix/CORE-249/returning-user-status-text-to-apps branch May 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants