-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: returning user status text for apps #32314
fix: returning user status text for apps #32314
Conversation
🦋 Changeset detectedLatest commit: d06681c The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32314 +/- ##
===========================================
+ Coverage 55.58% 55.61% +0.03%
===========================================
Files 2405 2405
Lines 52929 52929
Branches 10872 10872
===========================================
+ Hits 29421 29438 +17
+ Misses 20907 20894 -13
+ Partials 2601 2597 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
6310a53
to
b5d3eeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add tests in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's not lose sight of those tests though :)
Proposed changes (including videos or screenshots)
This PR adds the user status text in the user bridge response.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-249
Steps to test or reproduce
Further comments