Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(E2EEncryption): File encryption support #32316

Merged
merged 77 commits into from
Jun 22, 2024
Merged

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Apr 25, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Task: E2EE2-4

Steps to test or reproduce

Further comments

  • Move msg to inside content
  • Hack to be able to download files on chrome
  • Decide if the APIs will be under room domain
  • Decide what to show when e2ee is disabled (check skipped test)
  • Cronjob to remove temporary files older than X hours
  • Mark uploaded files as temporary
  • Mark as non temporary when sending the message
  • Anonimize file name
  • Decide if content will be string and data
  • Decide if the key info will be inside the attachment info
  • Should simplify the data structure and make it compatible on read?
  • Deprecate old upload API
  • Prepare API to accept multiple files on media confirm?
  • Tests
    • Old format message
    • New Upload API
      • Current old API tests
      • Media Confirm access only
      • Not confirmed media access
      • Auto removal of not confirmed media?
  • Update Docs
  • Client generated data:
    • Thumbs?
    • Blurred background?
    • Extra file info? Width, Height

Copy link
Contributor

dionisio-bot bot commented Apr 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 1b8e725

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 64.84848% with 58 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (865a5aa) to head (47302e6).
Report is 1 commits behind head on develop.

Current head 47302e6 differs from pull request most recent head 1b8e725

Please upload reports for the commit 1b8e725 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32316      +/-   ##
===========================================
+ Coverage    56.55%   56.60%   +0.04%     
===========================================
  Files         2491     2488       -3     
  Lines        55102    55105       +3     
  Branches     11400    11408       +8     
===========================================
+ Hits         31165    31190      +25     
+ Misses       21246    21233      -13     
+ Partials      2691     2682       -9     
Flag Coverage Δ
e2e 56.24% <64.84%> (+0.08%) ⬆️
unit 71.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok added this to the 6.9 milestone May 9, 2024
@milton-rucks milton-rucks modified the milestones: 6.10, 7.0 Jun 21, 2024
@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Jun 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2024
@rodrigok rodrigok marked this pull request as ready for review June 21, 2024 21:00
@rodrigok rodrigok requested review from a team as code owners June 21, 2024 21:00
@ggazzo ggazzo merged commit 161813c into develop Jun 22, 2024
11 of 12 checks passed
@ggazzo ggazzo deleted the feat/encrypted-files branch June 22, 2024 03:06
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants