-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on instances endpoints #32334
chore!: Improve permissions check on instances endpoints #32334
Conversation
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32334 +/- ##
=================================================
- Coverage 55.56% 55.54% -0.02%
=================================================
Files 2333 2333
Lines 51578 51578
Branches 10526 10526
=================================================
- Hits 28657 28650 -7
- Misses 20403 20410 +7
Partials 2518 2518
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
instances
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-341
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.