Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AttachmentAuthorName missing color token #32342

Merged
merged 5 commits into from
May 2, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Apr 30, 2024

This PR depends on the fuselage changes made on this PR to add the missing color token.
Bumping to version 0.53.6

Proposed changes (including videos or screenshots)

image
image

Issue(s)

Steps to test or reproduce

Further comments

DSAR-487

Copy link
Contributor

dionisio-bot bot commented Apr 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: c29b7e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliajforesti juliajforesti marked this pull request as ready for review April 30, 2024 14:10
@juliajforesti juliajforesti requested a review from a team as a code owner April 30, 2024 14:10
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (92cf2b6) to head (c29b7e4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32342      +/-   ##
===========================================
- Coverage    55.54%   55.50%   -0.05%     
===========================================
  Files         2403     2402       -1     
  Lines        52847    52833      -14     
  Branches     10854    10854              
===========================================
- Hits         29352    29323      -29     
- Misses       20894    20900       +6     
- Partials      2601     2610       +9     
Flag Coverage Δ
e2e 54.73% <ø> (-0.04%) ⬇️
unit 73.48% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti requested a review from a team as a code owner April 30, 2024 19:28
@dougfabris dougfabris added this to the 6.9 milestone Apr 30, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label May 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 2, 2024
@kodiakhq kodiakhq bot merged commit 651e093 into develop May 2, 2024
43 checks passed
@kodiakhq kodiakhq bot deleted the fix/attachment-author-color branch May 2, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants