-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: PbxEvents out of DB Watcher #32372
Conversation
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32372 +/- ##
===========================================
+ Coverage 55.55% 55.56% +0.01%
===========================================
Files 2397 2401 +4
Lines 52789 52845 +56
Branches 10851 10861 +10
===========================================
+ Hits 29325 29362 +37
- Misses 20865 20882 +17
- Partials 2599 2601 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
848df67
to
c5de6fa
Compare
apps/meteor/server/services/voip-asterisk/connector/asterisk/ami/ContinuousMonitor.ts
Outdated
Show resolved
Hide resolved
…cketChat/Rocket.Chat into refactor/pbx-events-out-of-db-watcher
As per the updates mentioned in PROJ-7 SCA-4 and ADR #74, this pull request focuses on relocating PbxEvent entity out of DB Watcher service.
Quick context to public readers
In essence, this modification empowers RocketChat's app to directly call listeners through the
api.broadcast
global function, eliminating the reliance on MongoDB Change Stream data propagationWhy is this beneficial? It provides better control over notifying users by enabling more precise use-case management. Unlike Change Streams, which notify every action on Mongo's documents and sometimes might result in unnecessary duplicate notifications. Moreover, it contributes to the future removal of the DB Watcher deployment, thereby optimizing resource utilization.
Proposed changes
Key changes include:
dbWatchersDisabled
flag.watch.pbxevents
listener event, subject to thedbWatchersDisabled
flag.Updated use cases.
Steps to test or reproduce
DISABLE_DB_WATCHERS
flag set to true.Further comments
To maintain consistency and avoid potential regressions, event names and signatures have been kept unchanged on both the client and app sides. This decision streamlines efforts and mitigates the risk of unintended consequences.