Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: PbxEvents out of DB Watcher #32372

Merged
merged 8 commits into from
May 13, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented May 6, 2024

As per the updates mentioned in PROJ-7 SCA-4 and ADR #74, this pull request focuses on relocating PbxEvent entity out of DB Watcher service.

Quick context to public readers

In essence, this modification empowers RocketChat's app to directly call listeners through the api.broadcast global function, eliminating the reliance on MongoDB Change Stream data propagation

Why is this beneficial? It provides better control over notifying users by enabling more precise use-case management. Unlike Change Streams, which notify every action on Mongo's documents and sometimes might result in unnecessary duplicate notifications. Moreover, it contributes to the future removal of the DB Watcher deployment, thereby optimizing resource utilization.

Proposed changes

Key changes include:

  • Conditionally incorporating PbxEvent entity import within DB watchers on application startup based on the dbWatchersDisabled flag.
  • Enabling support for the following use cases to directly trigger watch.pbxevents listener event, subject to the dbWatchersDisabled flag.
Updated use cases.
Use Case Route/Trigger Notes
manageDialEvents
storePbxEvent

Steps to test or reproduce

  1. Start RocketChat's application with the DISABLE_DB_WATCHERS flag set to true.
  2. Start or end a VOIP call to pass through the events. As an agent, you should be able to observe the status and details of the call seamlessly, without any discernible difference from when it's within the DB watcher version.

Further comments

To maintain consistency and avoid potential regressions, event names and signatures have been kept unchanged on both the client and app sides. This decision streamlines efforts and mitigates the risk of unintended consequences.

Copy link

changeset-bot bot commented May 6, 2024

⚠️ No Changeset found

Latest commit: 939dbc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented May 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@ricardogarim ricardogarim changed the title refactor: pbxEvents out of DB Watcher refactor: PbxEvents out of DB Watcher May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 55.56%. Comparing base (2671a21) to head (939dbc6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32372      +/-   ##
===========================================
+ Coverage    55.55%   55.56%   +0.01%     
===========================================
  Files         2397     2401       +4     
  Lines        52789    52845      +56     
  Branches     10851    10861      +10     
===========================================
+ Hits         29325    29362      +37     
- Misses       20865    20882      +17     
- Partials      2599     2601       +2     
Flag Coverage Δ
e2e 54.87% <ø> (+0.02%) ⬆️
unit 73.37% <12.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim force-pushed the refactor/pbx-events-out-of-db-watcher branch from 848df67 to c5de6fa Compare May 10, 2024 01:11
@ricardogarim ricardogarim marked this pull request as ready for review May 10, 2024 01:51
@ricardogarim ricardogarim requested review from a team as code owners May 10, 2024 01:51
@ricardogarim ricardogarim requested a review from a team as a code owner May 10, 2024 13:33
@sampaiodiego sampaiodiego added this to the 6.9 milestone May 13, 2024
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label May 13, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 13, 2024
@kodiakhq kodiakhq bot merged commit 3b06229 into develop May 13, 2024
52 checks passed
@kodiakhq kodiakhq bot deleted the refactor/pbx-events-out-of-db-watcher branch May 13, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants