Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename VoIP service to VoipAsterisk #32377

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented May 6, 2024

Proposed changes (including videos or screenshots)

We're creating a new VoIP server based on FreeSwitch, using the same interface as the existing VoIP service. To avoid confusion, this PR is renaming the existing service to VoIPAsterisk since it contains only the implementations related to Asterisk.

Issue(s)

VOIP-25

Steps to test or reproduce

QA tests to ensure this change didn't break anything:

  • Server should continue to start up without any new issue
  • List VoIP extensions on the admin screen
  • Assign an agent to an extension
  • API: voip/managementServer/checkConnection should be unaffected
  • API: voip/callServer/checkConnection should be unaffected

Further comments

Copy link
Contributor

dionisio-bot bot commented May 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 6, 2024

⚠️ No Changeset found

Latest commit: de3013d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.9 milestone May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (dd0bbce) to head (de3013d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32377      +/-   ##
===========================================
+ Coverage    55.56%   55.58%   +0.02%     
===========================================
  Files         2404     2398       -6     
  Lines        52897    52820      -77     
  Branches     10863    10849      -14     
===========================================
- Hits         29390    29360      -30     
+ Misses       20906    20874      -32     
+ Partials      2601     2586      -15     
Flag Coverage Δ
e2e 54.86% <ø> (+0.05%) ⬆️
unit 73.55% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review May 6, 2024 21:04
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners May 6, 2024 21:04
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label May 7, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 7, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 7, 2024
@pierre-lehnen-rc pierre-lehnen-rc added the stat: ready to merge PR tested and approved waiting for merge label May 8, 2024
@kodiakhq kodiakhq bot merged commit 5d1cb28 into develop May 8, 2024
41 checks passed
@kodiakhq kodiakhq bot deleted the chore/rename-voip-service branch May 8, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants