fix: saveSettings endpoint allowing NaN to be stored on Int settings #32428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 757b386 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32428 +/- ##
========================================
Coverage 55.15% 55.15%
========================================
Files 2397 2394 -3
Lines 53221 53186 -35
Branches 10952 10948 -4
========================================
- Hits 29353 29337 -16
+ Misses 21275 21266 -9
+ Partials 2593 2583 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
requested changes
May 27, 2024
KevLehman
requested changes
May 28, 2024
MarcosSpessatto
requested changes
Jun 3, 2024
MarcosSpessatto
previously approved these changes
Jun 3, 2024
debdutdeb
reviewed
Jun 3, 2024
debdutdeb
previously requested changes
Jun 3, 2024
There was a problem hiding this comment.
the value is fetched from db, and looks like can possibly be NaN. this tells me the save action is what should always set empty number setting type values to zero, and not be handled as an exception for this specific method.
please help me if I'm missing something.
debdutdeb
dismissed
their stale review
nvm I was rushing my review and misread, sorry.
KevLehman
previously approved these changes
Jun 5, 2024
matheusbsilva137
requested changes
Jun 11, 2024
Co-authored-by: Matheus Barbosa Silva <[email protected]>
MartinSchoeler
dismissed stale reviews from KevLehman and MarcosSpessatto
via
e947932
matheusbsilva137
requested changes
Jun 12, 2024
matheusbsilva137
approved these changes
Jun 12, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Jun 19, 2024
yash-rajpal
approved these changes
Jun 19, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-418
Fixes issue that allowed empty strings to be saved in the int settings, causing an NaN value on the DB