Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix messaging flaky e2e test #32429

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented May 13, 2024

Proposed changes (including videos or screenshots)

Fixes the test: should focus the latest message when moving the focus on the list and theres no previous focus

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: 40e7751

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented May 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris changed the title fix: Messaging flaky e2e test test: Fix messaging flaky e2e test May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.42%. Comparing base (4b6951b) to head (40e7751).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32429      +/-   ##
===========================================
- Coverage    55.63%   54.42%   -1.21%     
===========================================
  Files         2408     2328      -80     
  Lines        52965    51777    -1188     
  Branches     10884    10657     -227     
===========================================
- Hits         29469    28182    -1287     
- Misses       20888    21078     +190     
+ Partials      2608     2517      -91     
Flag Coverage Δ
e2e 52.77% <ø> (-2.29%) ⬇️
unit 73.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review May 13, 2024 20:33
@dougfabris dougfabris requested a review from a team as a code owner May 13, 2024 20:33
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label May 14, 2024
@dougfabris dougfabris added this to the 6.9 milestone May 14, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 14, 2024
@kodiakhq kodiakhq bot merged commit 18cae03 into develop May 14, 2024
41 of 45 checks passed
@kodiakhq kodiakhq bot deleted the test/flaky-focus-recent-message branch May 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants