fix: QueueInactivityMonitor not processing inquiries
#32452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 80cb3dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32452 +/- ##
===========================================
+ Coverage 56.47% 56.56% +0.08%
===========================================
Files 2482 2483 +1
Lines 54620 54663 +43
Branches 11283 11280 -3
===========================================
+ Hits 30849 30918 +69
+ Misses 21101 21071 -30
- Partials 2670 2674 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Note: no tests for this as the minimum time for this job to run is one min and waiting for the CI to run after one min is no good Will create a separate task to add unit tests |
MarcosSpessatto
requested changes
May 20, 2024
apps/meteor/ee/app/livechat-enterprise/server/hooks/afterInquiryQueued.ts
Outdated
Show resolved
Hide resolved
MarcosSpessatto
previously approved these changes
May 23, 2024
MartinSchoeler
previously approved these changes
Jun 5, 2024
KevLehman
dismissed stale reviews from MartinSchoeler and MarcosSpessatto
via
5c908a2
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MartinSchoeler
approved these changes
Jun 18, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
apps/meteor/ee/tests/unit/apps/livechat-enterprise/server/hooks/afterInquiryQueued.spec.ts
Show resolved
Hide resolved
MarcosSpessatto
approved these changes
Jun 18, 2024
KevLehman
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-579
Steps to test or reproduce
Further comments
Apparently the callback that created the job to remove the items from the queue was checking a
createdAtproperty that didn't even exists on types. Since the function was typed asany, this created the perfect place for this happen.Types were updated, missing property check was removed (now we just check for _updatedAt) and changed the use of a global value since we have the value in scope from the
watchcall.