Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Livechat): transferChat Livechat api endpoint #32498

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented May 24, 2024

SUP-577

Created a transferChat Livechat API endpoint for transferring chats programmatically, the endpoint has all the limitations & permissions required that transferring via UI has

Copy link
Contributor

dionisio-bot bot commented May 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 60235d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/livechat Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 6.9 milestone May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (eb5f93c) to head (60235d7).
Report is 65 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32498      +/-   ##
===========================================
+ Coverage    56.73%   56.81%   +0.07%     
===========================================
  Files         2498     2498              
  Lines        55385    55335      -50     
  Branches     11455    11411      -44     
===========================================
+ Hits         31424    31437      +13     
+ Misses       21256    21216      -40     
+ Partials      2705     2682      -23     
Flag Coverage Δ
e2e 56.45% <ø> (-0.04%) ⬇️
unit 72.47% <ø> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review May 27, 2024 11:06
@MartinSchoeler MartinSchoeler requested review from a team as code owners May 27, 2024 11:06
@scuciatto scuciatto modified the milestones: 6.9, 6.10 May 27, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more info to the description?

Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the lint?

MarcosSpessatto
MarcosSpessatto previously approved these changes Jun 3, 2024
@scuciatto scuciatto added this to the 6.11 milestone Jul 3, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changeset?

@MartinSchoeler MartinSchoeler changed the title feat(Livechat): setDefaultDepartmentField & setGuestDepartment livechat api endpoints feat(Livechat): transferChat Livechat api endpoint Jul 5, 2024
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
MarcosSpessatto
MarcosSpessatto previously approved these changes Jul 8, 2024
.changeset/afraid-guests-jog.md Outdated Show resolved Hide resolved
packages/livechat/src/lib/hooks.ts Show resolved Hide resolved
packages/livechat/src/lib/hooks.ts Show resolved Hide resolved
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 12, 2024
@ggazzo ggazzo merged commit 8d76339 into develop Jul 12, 2024
50 checks passed
@ggazzo ggazzo deleted the deprecate-set-department branch July 12, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants