-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent broadcasting of system messages when hide setting is enabled #32522
fix: prevent broadcasting of system messages when hide setting is enabled #32522
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ffc4b55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32522 +/- ##
===========================================
+ Coverage 55.70% 56.44% +0.73%
===========================================
Files 2416 2481 +65
Lines 53471 54617 +1146
Branches 11002 11283 +281
===========================================
+ Hits 29787 30826 +1039
- Misses 21058 21108 +50
- Partials 2626 2683 +57
Flags with carried forward coverage won't be shown. Click here to find out more. |
1301b0b
to
38800b1
Compare
apps/meteor/tests/unit/server/modules/watchers/lib/messages.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/app/lib/server/lib/getHiddenSystemMessage.spec.ts
Show resolved
Hide resolved
10afc76
to
6d51400
Compare
6d51400
to
71061cd
Compare
79c05e4
to
0402cab
Compare
ca7a74f
to
a322e44
Compare
…n-hide-system-message-is-set
…n-hide-system-message-is-set
Proposed changes (including videos or screenshots)
This change ensures that system messages are not broadcasted when the setting to hide system messages is enabled. By checking the Hide_System_Messages configuration, the system will prevent unnecessary message broadcasts, improving message handling efficiency. This fix guarantees adherence to user-defined visibility settings for system messages.
Issue(s)
SUP-559
Steps to test or reproduce
Further comments
This update will enhance the efficiency of message handling by preventing the broadcast of system messages when configured to do so. This helps in maintaining cleaner logs and better performance in scenarios where certain system messages are not needed.