fix: Accounts_LoginExpiration being used differently on codebase

[KevLehman]

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-574

Steps to test or reproduce

Further comments

Fixed an inconsistent evaluation of the Accounts_LoginExpiration setting over the codebase. In some places, it was being used as milliseconds while in others as days. Invalid values produced different results. A helper function was created to centralize the setting validation and the proper value being returned to avoid edge cases.
Negative values may be saved on the settings UI panel but the code will interpret any negative, NaN or 0 value to the default expiration which is 90 days.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 39affda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/tools	Patch
@rocket.chat/account-service	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.49%. Comparing base (eff91b4) to head (39affda).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32527      +/-   ##
===========================================
- Coverage    55.51%   55.49%   -0.02%     
===========================================
  Files         2632     2632              
  Lines        57174    57174              
  Branches     11841    11841              
===========================================
- Hits         31740    31730      -10     
- Misses       22746    22762      +16     
+ Partials      2688     2682       -6     

Flag	Coverage Δ
e2e	54.22% <ø> (-0.06%)	⬇️
unit	72.13% <ø> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.