Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove meteor/check from chat endpoints #32532

Merged
merged 5 commits into from
Aug 17, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented May 31, 2024

Proposed changes (including videos or screenshots)

  • Remove meteor/check from chat endpoints by using the validateParams property.

Issue(s)

CORE-316

Steps to test or reproduce

Further comments

The intention for this PR is to improve code readability and make invalid params errors more standardized. No side effects are expected. We're considering this a breaking change since invalid params errors are being changed to follow the same standard when possible.

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone May 31, 2024
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners May 31, 2024 16:22
Copy link
Contributor

dionisio-bot bot commented May 31, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: b1e551d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/rest-typings Major
@rocket.chat/core-services Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matheusbsilva137 matheusbsilva137 changed the title chore: Chore/remove meteor check chat chore!: Remove meteor/check from chat endpoints May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (77defb5) to head (b1e551d).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #32532   +/-   ##
==============================================
  Coverage          59.40%   59.40%           
==============================================
  Files               2541     2541           
  Lines              63173    63173           
  Branches           14220    14220           
==============================================
  Hits               37525    37525           
  Misses             22933    22933           
  Partials            2715     2715           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/tests/end-to-end/api/05-chat.js Outdated Show resolved Hide resolved
packages/rest-typings/src/v1/chat.ts Outdated Show resolved Hide resolved
packages/rest-typings/src/v1/chat.ts Outdated Show resolved Hide resolved
@ggazzo ggazzo requested a review from a team as a code owner June 11, 2024 13:15
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from ea82dad to 7e69ab1 Compare June 11, 2024 17:57
@matheusbsilva137 matheusbsilva137 requested review from MarcosSpessatto and removed request for a team June 12, 2024 19:30
@ggazzo ggazzo dismissed MarcosSpessatto’s stale review June 19, 2024 04:08

The merge-base changed after approval.

@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from bc4fad7 to b484993 Compare June 24, 2024 11:48
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from b285fd4 to 39a6fe1 Compare July 16, 2024 15:10
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from ce44882 to d94b784 Compare July 29, 2024 19:47
@ggazzo ggazzo requested a review from a team as a code owner August 16, 2024 13:09
@matheusbsilva137 matheusbsilva137 requested review from a team and removed request for a team August 16, 2024 13:39
@ggazzo ggazzo force-pushed the chore/remove-check-meteor-chat branch from 8537369 to d2c8cfc Compare August 17, 2024 02:10
ggazzo
ggazzo previously approved these changes Aug 17, 2024
@ggazzo ggazzo merged commit 4e90c43 into release-7.0.0 Aug 17, 2024
48 of 49 checks passed
@ggazzo ggazzo deleted the chore/remove-check-meteor-chat branch August 17, 2024 03:20
ggazzo added a commit that referenced this pull request Aug 20, 2024
ggazzo added a commit that referenced this pull request Sep 5, 2024
ggazzo added a commit that referenced this pull request Sep 5, 2024
ggazzo added a commit that referenced this pull request Sep 5, 2024
ggazzo added a commit that referenced this pull request Sep 11, 2024
ggazzo added a commit that referenced this pull request Sep 13, 2024
ggazzo added a commit that referenced this pull request Sep 13, 2024
ggazzo added a commit that referenced this pull request Sep 14, 2024
ggazzo added a commit that referenced this pull request Sep 16, 2024
MartinSchoeler pushed a commit that referenced this pull request Sep 18, 2024
ggazzo added a commit that referenced this pull request Sep 25, 2024
ggazzo added a commit that referenced this pull request Sep 25, 2024
ggazzo added a commit that referenced this pull request Sep 27, 2024
ggazzo added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: core stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants