Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: removed listEmojiCustom method #32542

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Jun 3, 2024

Proposed changes (including videos or screenshots)

removed listEmojiCustom method as it has been replaced with emoji-custom.list endpoint

Issue(s)

Steps to test or reproduce

Further comments

CORE-355

Copy link
Contributor

dionisio-bot bot commented Jun 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: e1a7cfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.71%. Comparing base (b484993) to head (e1a7cfd).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #32542      +/-   ##
=================================================
- Coverage          56.71%   56.71%   -0.01%     
=================================================
  Files               2496     2496              
  Lines              55357    55357              
  Branches           11455    11455              
=================================================
- Hits               31397    31393       -4     
- Misses             21260    21295      +35     
+ Partials            2700     2669      -31     
Flag Coverage Δ
unit 71.92% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin marked this pull request as ready for review June 3, 2024 14:12
MarcosSpessatto
MarcosSpessatto previously approved these changes Jun 3, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a better replacement for this method would be the endpoint emoji-custom.all instead of emoji-custom.list

@MarcosSpessatto MarcosSpessatto added this to the 7.0 milestone Jun 3, 2024
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 3, 2024
@ggazzo ggazzo dismissed MarcosSpessatto’s stale review June 11, 2024 13:15

The merge-base changed after approval.

@ggazzo ggazzo requested review from a team as code owners June 11, 2024 13:15
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from ea82dad to 7e69ab1 Compare June 11, 2024 17:57
@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from bc4fad7 to b484993 Compare June 24, 2024 11:48
@ggazzo ggazzo force-pushed the refactor/remove-listEmojiCustom-method branch from bc0d194 to 263036c Compare June 24, 2024 19:23
@ggazzo ggazzo force-pushed the refactor/remove-listEmojiCustom-method branch from 263036c to e1a7cfd Compare June 24, 2024 19:24
@ggazzo ggazzo merged commit 76951f5 into release-7.0.0 Jun 24, 2024
19 checks passed
@ggazzo ggazzo deleted the refactor/remove-listEmojiCustom-method branch June 24, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants