-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: removed listEmojiCustom method #32542
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32542 +/- ##
=================================================
- Coverage 56.71% 56.71% -0.01%
=================================================
Files 2496 2496
Lines 55357 55357
Branches 11455 11455
=================================================
- Hits 31397 31393 -4
- Misses 21260 21295 +35
+ Partials 2700 2669 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe a better replacement for this method would be the endpoint emoji-custom.all
instead of emoji-custom.list
The merge-base changed after approval.
ea82dad
to
7e69ab1
Compare
bc4fad7
to
b484993
Compare
bc0d194
to
263036c
Compare
Signed-off-by: Abhinav Kumar <[email protected]>
263036c
to
e1a7cfd
Compare
Proposed changes (including videos or screenshots)
removed listEmojiCustom method as it has been replaced with
emoji-custom.list
endpointIssue(s)
Steps to test or reproduce
Further comments
CORE-355