-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Disable slash commands for encrypted rooms #32548
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 220a40c The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32548 +/- ##
===========================================
+ Coverage 55.02% 55.13% +0.10%
===========================================
Files 2390 2394 +4
Lines 53126 53186 +60
Branches 10933 10945 +12
===========================================
+ Hits 29234 29322 +88
+ Misses 21312 21271 -41
- Partials 2580 2593 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
Slash commands are executed client side aren't they? Won't some still work just the output not encrypted? |
You are right @geekgonecrazy but in latest versions we introduced a new setting and behavior that un-encrypted messages won't be allowed in encrypted rooms. Also, currently we have no way of knowing which apps and slash-commands won't work with encrypted messages and channels, so we decided to block all apps and slashcommands. |
I also think that we need to revisit this, maybe encrypt messages sent by apps/bots if the settings that allow unencrypted messages is enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow bots and apps if the "Unencrypted messages in encrypted rooms" is enabled
I don't think that is something possible with current architecture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it's missing tests too 🫣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes (including videos or screenshots)
Currently, several apps and bots don’t work properly in E2EE rooms
So, it is needed to make clear to users that it is not possible to use apps and slash commands if E2EE is enabled in the room.
Issue(s)
Steps to test or reproduce
Further comments
E2EE-24