Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): Align Jest tests #32550

Merged
merged 22 commits into from
Aug 11, 2024
Merged

refactor(tests): Align Jest tests #32550

merged 22 commits into from
Aug 11, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 4, 2024

Proposed changes (including videos or screenshots)

This pull request:

  • colocates unit tests along with the units that are tested i.e. the referred modules;
  • fixes broken or malformed unit tests (e.g. ModalProvider tests);
  • remove obsolete test configurations;
  • upgrades Testing Library but keeps it working with React 17;
  • unifies Jest configurations;
  • replaces ts-jest with @swc/jest.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 4, 2024

⚠️ No Changeset found

Latest commit: 2da23cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.41%. Comparing base (4ec97ed) to head (2da23cb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32550      +/-   ##
===========================================
+ Coverage    56.10%   59.41%   +3.30%     
===========================================
  Files         2462     2541      +79     
  Lines        54234    63187    +8953     
  Branches     11174    14221    +3047     
===========================================
+ Hits         30427    37540    +7113     
- Misses       21182    22931    +1749     
- Partials      2625     2716      +91     
Flag Coverage Δ
unit 76.06% <ø> (+3.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/jest-tests branch 7 times, most recently from 337927b to 651f0c0 Compare June 25, 2024 14:01
@tassoevan tassoevan added this to the 6.11 milestone Jun 25, 2024
@tassoevan tassoevan force-pushed the refactor/jest-tests branch 3 times, most recently from 02a32d7 to b92b394 Compare July 2, 2024 20:03
@tassoevan tassoevan force-pushed the refactor/jest-tests branch 2 times, most recently from 65bc50f to d95ae29 Compare July 16, 2024 14:55
@tassoevan tassoevan removed this from the 6.11 milestone Jul 22, 2024
@tassoevan tassoevan force-pushed the refactor/jest-tests branch 3 times, most recently from 3f53f62 to 99d8d82 Compare August 9, 2024 14:29
@tassoevan tassoevan added this to the 6.12 milestone Aug 10, 2024
@tassoevan tassoevan marked this pull request as ready for review August 10, 2024 04:14
@tassoevan tassoevan requested review from a team as code owners August 10, 2024 04:14
@ggazzo ggazzo merged commit 27bd512 into develop Aug 11, 2024
49 checks passed
@ggazzo ggazzo deleted the refactor/jest-tests branch August 11, 2024 23:38
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants