Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run QueryClient.clear() on logout #32587

Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix: Run QueryClient.clear() on logout #32587

merged 4 commits into from
Jun 12, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 11, 2024

Fixes issues with loading license modules when loading the page while logged out
Fixes Error getting modules i {revert: undefined, silent: true} error

SUP-595

Copy link
Contributor

dionisio-bot bot commented Jun 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: a7d4c12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.37%. Comparing base (c4e59b9) to head (a7d4c12).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32587      +/-   ##
===========================================
- Coverage    56.42%   56.37%   -0.05%     
===========================================
  Files         2450     2446       -4     
  Lines        54010    53963      -47     
  Branches     11131    11124       -7     
===========================================
- Hits         30477    30424      -53     
- Misses       20875    20879       +4     
- Partials      2658     2660       +2     
Flag Coverage Δ
e2e 56.13% <100.00%> (-0.11%) ⬇️
unit 71.82% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler
Copy link
Contributor Author

As expected the test fails
Screenshot 2024-06-11 at 17 01 40

@MartinSchoeler MartinSchoeler added this to the 6.10 milestone Jun 11, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 11, 2024 21:08
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 11, 2024 21:08
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 12, 2024
@kodiakhq kodiakhq bot merged commit 972ba42 into develop Jun 12, 2024
60 checks passed
@kodiakhq kodiakhq bot deleted the fix-license-error branch June 12, 2024 11:53
@ggazzo
Copy link
Member

ggazzo commented Jun 12, 2024

/patch

Copy link
Contributor

dionisio-bot bot commented Jun 12, 2024

Pull request #32591 added to Project: "Patch 6.9.1"

@ggazzo
Copy link
Member

ggazzo commented Jun 12, 2024

/backport 6.8.1

Copy link
Contributor

dionisio-bot bot commented Jun 12, 2024

Pull request #32594 added to Project: "Patch 6.8.1"

@ggazzo
Copy link
Member

ggazzo commented Jun 12, 2024

/backport 6.7.4

Copy link
Contributor

dionisio-bot bot commented Jun 12, 2024

Pull request #32597 added to Project: "Patch 6.7.4"

@ggazzo
Copy link
Member

ggazzo commented Jun 12, 2024

/backport 6.6.9

Copy link
Contributor

dionisio-bot bot commented Jun 12, 2024

Pull request #32599 added to Project: "Patch 6.6.9"

This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants