Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade fuselage-toastbar adding RTL support #32604

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 13, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-523

Copy link
Contributor

dionisio-bot bot commented Jun 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: ab8fd15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/uikit-playground Minor
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (afa560d) to head (ab8fd15).
Report is 28 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32604      +/-   ##
===========================================
+ Coverage    56.43%   56.44%   +0.01%     
===========================================
  Files         2455     2454       -1     
  Lines        54098    54067      -31     
  Branches     11149    11143       -6     
===========================================
- Hits         30529    30517      -12     
+ Misses       20909    20890      -19     
  Partials      2660     2660              
Flag Coverage Δ
e2e 56.21% <ø> (+0.01%) ⬆️
unit 71.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.10 milestone Jun 13, 2024
@dougfabris dougfabris marked this pull request as ready for review June 13, 2024 20:20
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2024
@ggazzo ggazzo merged commit c0828b4 into develop Jun 21, 2024
52 checks passed
@ggazzo ggazzo deleted the feat/toastbar-rtl branch June 21, 2024 02:03
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants