Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change Quote Position #32605

Merged
merged 5 commits into from
Jun 21, 2024
Merged

feat: Change Quote Position #32605

merged 5 commits into from
Jun 21, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 13, 2024

Proposed changes (including videos or screenshots)

Moves the quotes to be on top of the message for better readability

Screenshot 2024-06-13 at 17 25 28

Issue(s)

Closes RocketChat/feature-requests#688
Closes RocketChat/feature-requests#721

Steps to test or reproduce

Further comments

CORE-501

Copy link
Contributor

dionisio-bot bot commented Jun 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 8468f30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.49%. Comparing base (afa560d) to head (8468f30).
Report is 28 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32605      +/-   ##
===========================================
+ Coverage    56.43%   56.49%   +0.06%     
===========================================
  Files         2455     2455              
  Lines        54098    54106       +8     
  Branches     11149    11155       +6     
===========================================
+ Hits         30529    30569      +40     
+ Misses       20909    20883      -26     
+ Partials      2660     2654       -6     
Flag Coverage Δ
e2e 56.25% <100.00%> (+0.05%) ⬆️
unit 72.00% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler added this to the 6.10 milestone Jun 13, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 14, 2024 11:45
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 14, 2024 11:45
@scuciatto scuciatto removed this from the 6.10 milestone Jun 17, 2024
@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2024
@milton-rucks milton-rucks added this to the 6.10 milestone Jun 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggazzo ggazzo merged commit 832ae0f into develop Jun 21, 2024
50 checks passed
@ggazzo ggazzo deleted the feat/quote-position branch June 21, 2024 02:02
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reply below quote Display quoted message above the user message
6 participants