-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable encryption for direct/private rooms by default is overriding E2EE setting #32624
Conversation
🦋 Changeset detectedLatest commit: 3cc5f0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32624 +/- ##
===========================================
- Coverage 56.54% 55.96% -0.59%
===========================================
Files 2484 2421 -63
Lines 54743 53600 -1143
Branches 11305 11036 -269
===========================================
- Hits 30955 29997 -958
+ Misses 21106 20979 -127
+ Partials 2682 2624 -58
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
We have a setting to force creation of new private groups as encrypted rooms. This setting was being applied even when the entire e2ee feature was disabled. We should not apply this setting when the feature is not enabled. So checking if the E2EE feature is enabled before applying this setting
Issue(s)
Steps to test or reproduce
Further comments
E2EE2-29