-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Livechat): Restore missing setDepartment livechat API endpoint functionality #32626
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: bea6d72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32626 +/- ##
===========================================
- Coverage 56.76% 56.69% -0.08%
===========================================
Files 2496 2498 +2
Lines 55358 55390 +32
Branches 11455 11457 +2
===========================================
- Hits 31423 31401 -22
- Misses 21241 21283 +42
- Partials 2694 2706 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
5f713f1
to
7cb4ff8
Compare
apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-api.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can we have a better explained title?
apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-api.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-api.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-api.spec.ts
Outdated
Show resolved
Hide resolved
/patch |
Pull request #32683 added to Project: "undefined" |
/backport 6.8.3 |
Pull request #32684 added to Project: "undefined" |
CORE-512
CORE-511
This PR fixes some behaviours that went missing on the
setDepartment
livechat api method: