Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Supported Versions misbehaving #32630

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jun 19, 2024

Backport of #32610

@dionisio-bot dionisio-bot bot requested a review from ggazzo June 19, 2024 02:38
Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: 7910c10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jun 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.54%. Comparing base (32cfa3e) to head (7910c10).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.6.10   #32630      +/-   ##
==================================================
- Coverage           54.56%   54.54%   -0.03%     
==================================================
  Files                2282     2280       -2     
  Lines               50265    50248      -17     
  Branches            10270    10265       -5     
==================================================
- Hits                27428    27408      -20     
+ Misses              20380    20354      -26     
- Partials             2457     2486      +29     
Flag Coverage Δ
e2e 53.39% <ø> (-0.04%) ⬇️
unit 76.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.6 milestone Jun 19, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@ggazzo ggazzo changed the title fix: Supported Versions misbehaving fix: Supported Versions misbehaving Jun 19, 2024
@ggazzo ggazzo merged commit 04b29f2 into release-6.6.10 Jun 19, 2024
48 checks passed
@ggazzo ggazzo deleted the backport-6.6.10-32610 branch June 19, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant