Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removed reportMessage method #32633

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Jun 19, 2024

Proposed changes (including videos or screenshots)

Removed reportMessage method as it has been replaced with chat.reportMessage.
Replaced the client call to the method with the endpoint call.

Issue(s)

Steps to test or reproduce

Further comments

CORE-360

Copy link

changeset-bot bot commented Jun 19, 2024

⚠️ No Changeset found

Latest commit: e7553a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jun 19, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (8c447cf) to head (e7553a3).
Report is 6 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #32633   +/-   ##
==============================================
  Coverage          59.39%   59.40%           
==============================================
  Files               2541     2541           
  Lines              63175    63173    -2     
  Branches           14220    14220           
==============================================
  Hits               37525    37525           
+ Misses             22935    22933    -2     
  Partials            2715     2715           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin force-pushed the refactor/remove-report-message-method branch from fd459bb to df2e554 Compare June 19, 2024 20:11
@abhinavkrin abhinavkrin marked this pull request as ready for review June 21, 2024 14:50
@abhinavkrin abhinavkrin requested review from a team as code owners June 21, 2024 14:50
@debdutdeb debdutdeb requested a review from Dnouv June 21, 2024 14:51
@abhinavkrin abhinavkrin marked this pull request as draft June 21, 2024 15:26
@abhinavkrin abhinavkrin force-pushed the refactor/remove-report-message-method branch from df2e554 to 79cd7bb Compare June 28, 2024 17:31
@abhinavkrin abhinavkrin marked this pull request as ready for review June 28, 2024 18:00
MarcosSpessatto
MarcosSpessatto previously approved these changes Jul 1, 2024
@MarcosSpessatto MarcosSpessatto added this to the 7.0 milestone Jul 1, 2024
yash-rajpal
yash-rajpal previously approved these changes Jul 4, 2024
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@debdutdeb debdutdeb removed the request for review from Dnouv July 8, 2024 08:09
@ggazzo ggazzo dismissed stale reviews from yash-rajpal and MarcosSpessatto July 16, 2024 14:12

The merge-base changed after approval.

@ggazzo ggazzo requested a review from a team as a code owner July 16, 2024 14:12
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from ce44882 to d94b784 Compare July 29, 2024 19:47
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 30f6f98 to 8c447cf Compare August 16, 2024 13:09
@ggazzo ggazzo force-pushed the refactor/remove-report-message-method branch from 79cd7bb to e7553a3 Compare August 16, 2024 17:35
@ggazzo ggazzo changed the title refactor!: removed reportMessage method chore!: removed reportMessage method Aug 17, 2024
@ggazzo ggazzo merged commit 10fce25 into release-7.0.0 Aug 17, 2024
50 checks passed
@ggazzo ggazzo deleted the refactor/remove-report-message-method branch August 17, 2024 00:49
ggazzo pushed a commit that referenced this pull request Sep 5, 2024
ggazzo pushed a commit that referenced this pull request Sep 5, 2024
ggazzo pushed a commit that referenced this pull request Sep 5, 2024
ggazzo pushed a commit that referenced this pull request Sep 11, 2024
ggazzo pushed a commit that referenced this pull request Sep 13, 2024
ggazzo pushed a commit that referenced this pull request Sep 13, 2024
ggazzo pushed a commit that referenced this pull request Sep 14, 2024
ggazzo pushed a commit that referenced this pull request Sep 16, 2024
ggazzo pushed a commit that referenced this pull request Sep 25, 2024
ggazzo pushed a commit that referenced this pull request Sep 25, 2024
ggazzo pushed a commit that referenced this pull request Sep 27, 2024
ggazzo pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants