Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User roles selection not persisting on editing in users admin panel #32671

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jun 25, 2024

Proposed changes (including videos or screenshots)

Currently when we edit user from admin user panel, we don't refetch the user details again on save, due to which the user edit form shows older info, like user roles. So now refetching the user info after saving the user.

Issue(s)

Steps to test or reproduce

  1. Log in as an admin user.
  2. Navigate to 'Workspace > Users'.
  3. Click on a user to view their details.
  4. Click on 'Edit'.
  5. In the 'Roles' field, select both 'owner' and 'user'.
  6. Save the changes.
  7. Reopen the edit window for the same user.

Further comments

CORE-39

Copy link
Contributor

dionisio-bot bot commented Jun 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: 71a3403

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.52%. Comparing base (7e8e003) to head (71a3403).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32671      +/-   ##
===========================================
+ Coverage    55.45%   55.52%   +0.07%     
===========================================
  Files         2637     2635       -2     
  Lines        57316    57283      -33     
  Branches     11869    11873       +4     
===========================================
+ Hits         31782    31809      +27     
+ Misses       22836    22751      -85     
- Partials      2698     2723      +25     
Flag Coverage Δ
e2e 53.97% <60.00%> (-0.07%) ⬇️
unit 72.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review June 25, 2024 22:24
@yash-rajpal yash-rajpal requested a review from a team as a code owner June 25, 2024 22:24
@yash-rajpal yash-rajpal added this to the 6.11 milestone Jun 26, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add some UI tests to ensure the behavior?

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
@yash-rajpal yash-rajpal added the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
@kodiakhq kodiakhq bot merged commit 1195dc2 into develop Jul 23, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/user-edit-roles branch July 23, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants