Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UiKit): Modal validation not working #32679

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jun 26, 2024

Proposed changes (including videos or screenshots)

Bring back modal validations response to inputs:

image

Issue(s)

Steps to test or reproduce

Further comments

CORE-469

Copy link
Contributor

dionisio-bot bot commented Jun 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: f454ae9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (35985d7) to head (f454ae9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32679      +/-   ##
===========================================
- Coverage    55.58%   55.55%   -0.03%     
===========================================
  Files         2635     2635              
  Lines        57289    57289              
  Branches     11864    11864              
===========================================
- Hits         31843    31828      -15     
- Misses       22750    22764      +14     
- Partials      2696     2697       +1     
Flag Coverage Δ
e2e 54.27% <ø> (-0.06%) ⬇️
unit 72.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review June 27, 2024 04:53
@tiagoevanp tiagoevanp requested a review from a team as a code owner June 27, 2024 04:53
@scuciatto scuciatto added this to the 6.11 milestone Jun 27, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests to ensure it?

MarcosSpessatto
MarcosSpessatto previously approved these changes Jul 5, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2024
@tiagoevanp tiagoevanp added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2024
@kodiakhq kodiakhq bot merged commit 88e5219 into develop Jul 22, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/validation-error-uikit branch July 22, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants