-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UiKit): Modal validation not working #32679
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f454ae9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32679 +/- ##
===========================================
- Coverage 55.58% 55.55% -0.03%
===========================================
Files 2635 2635
Lines 57289 57289
Branches 11864 11864
===========================================
- Hits 31843 31828 -15
- Misses 22750 22764 +14
- Partials 2696 2697 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests to ensure it?
…cket.Chat into fix/validation-error-uikit
…validation-error-uikit
5a0f0a7
to
430fce9
Compare
430fce9
to
362b9cf
Compare
Proposed changes (including videos or screenshots)
Bring back modal validations response to inputs:
Issue(s)
Steps to test or reproduce
Further comments
CORE-469