-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove hide option on omnichannel conversations #32691
fix: remove hide option on omnichannel conversations #32691
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a928359 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32691 +/- ##
===========================================
- Coverage 55.57% 55.55% -0.03%
===========================================
Files 2635 2635
Lines 57275 57276 +1
Branches 11861 11862 +1
===========================================
- Hits 31830 31818 -12
- Misses 22756 22764 +8
- Partials 2689 2694 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Tests to the RoomMenu are being made and they are going to be sent in another PR. |
Co-authored-by: Yash Rajpal <[email protected]>
This PR removes the hiding option on Omnichannel conversations that was causing an error when it is used since Omnichannel conversations are not meant to be hidden.
Proposed changes (including videos or screenshots)
Before:
When the hide option is clicked:
After:
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-599
Steps to test or reproduce
Further comments