Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hide option on omnichannel conversations #32691

Merged
merged 12 commits into from
Jul 20, 2024

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Jun 27, 2024

This PR removes the hiding option on Omnichannel conversations that was causing an error when it is used since Omnichannel conversations are not meant to be hidden.

⚠️ Tests to the RoomMenu are being made and they are going to be sent in another PR.

Proposed changes (including videos or screenshots)

Before:
When the hide option is clicked:
image

After:
image

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-599

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: a928359

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (7b9b950) to head (a928359).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32691      +/-   ##
===========================================
- Coverage    55.57%   55.55%   -0.03%     
===========================================
  Files         2635     2635              
  Lines        57275    57276       +1     
  Branches     11861    11862       +1     
===========================================
- Hits         31830    31818      -12     
- Misses       22756    22764       +8     
- Partials      2689     2694       +5     
Flag Coverage Δ
e2e 54.28% <100.00%> (-0.02%) ⬇️
unit 72.22% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto scuciatto added this to the 6.12 milestone Jul 19, 2024
@csuadev
Copy link
Contributor Author

csuadev commented Jul 19, 2024

Tests to the RoomMenu are being made and they are going to be sent in another PR.

@csuadev csuadev marked this pull request as ready for review July 19, 2024 18:17
@csuadev csuadev requested a review from a team as a code owner July 19, 2024 18:18
@csuadev csuadev modified the milestones: 6.12, 6.11 Jul 19, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2024
@kodiakhq kodiakhq bot merged commit e9fae8e into develop Jul 20, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/SUP-599-remove-option-oc-conversations branch July 20, 2024 01:52
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants