Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(E2EEncryption): Fix edition of encrypted messages not working #32700

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Jun 28, 2024

Proposed changes (including videos or screenshots)

Issue(s)

E2EE2-42
E2EE2-43

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@rodrigok rodrigok added this to the 6.10 milestone Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.64%. Comparing base (22719e0) to head (b74aed0).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.0   #32700      +/-   ##
==================================================
- Coverage           56.69%   56.64%   -0.06%     
==================================================
  Files                2497     2498       +1     
  Lines               55451    55470      +19     
  Branches            11453    11459       +6     
==================================================
- Hits                31436    31419      -17     
  Misses              21347    21347              
- Partials             2668     2704      +36     
Flag Coverage Δ
e2e 56.42% <66.66%> (-0.06%) ⬇️
unit 71.46% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok marked this pull request as ready for review June 28, 2024 21:16
@rodrigok rodrigok requested a review from a team as a code owner June 28, 2024 21:16
Copy link

changeset-bot bot commented Jun 29, 2024

⚠️ No Changeset found

Latest commit: b74aed0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Jul 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 1, 2024
@kodiakhq kodiakhq bot merged commit 7ee9ca1 into release-6.10.0 Jul 1, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the regression/fix-e2ee-message-edit branch July 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants