Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Creation Date col in Rooms Table in Admin Panel #32709

Merged
merged 17 commits into from
Aug 21, 2024

Conversation

heet434
Copy link
Contributor

@heet434 heet434 commented Jul 2, 2024

Proposed changes (including videos or screenshots)

Added a column that displays the room creation date.
Screenshot 2024-07-02 at 2 16 14 PM

Also added a ts field to retrieve the creation date from the database.

Issue(s)

Here's the link: RocketChat/feature-requests#893

Steps to test or reproduce

Open the Rooms section in Admin Panel. Need for a creation date column there.

Further comments

https://rocketchat.atlassian.net/browse/CONN-293

@heet434 heet434 requested review from a team as code owners July 2, 2024 08:54
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 3099a9b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution...

please, check the CI errors.

Take this PR as reference, we already have a function to format date.

@hugocostadev hugocostadev self-assigned this Jul 2, 2024
@heet434
Copy link
Contributor Author

heet434 commented Jul 2, 2024

Hi @hugocostadev , I have resolved the typecheck and lint errors, and used the useFormatDate function for formatting the date, but I can't find out as to what exactly is failing the unit test in @rocket.chat/license:testunit . Could you please help me out here?

@hugocostadev
Copy link
Contributor

Hi @hugocostadev , I have resolved the typecheck and lint errors, and used the useFormatDate function for formatting the date, but I can't find out as to what exactly is failing the unit test in @rocket.chat/license:testunit . Could you please help me out here?

Hey @heet434 I'll review it again! Thanks!

Related to the unit test, don't worry... it's expected, we are going to fix this internally

@heet434
Copy link
Contributor Author

heet434 commented Jul 2, 2024

Hi @hugocostadev , I have resolved the typecheck and lint errors, and used the useFormatDate function for formatting the date, but I can't find out as to what exactly is failing the unit test in @rocket.chat/license:testunit . Could you please help me out here?

Hey @heet434 I'll review it again! Thanks!

Related to the unit test, don't worry... it's expected, we are going to fix this internally

@hugocostadev Thank you! I'll add the commits that resolve the prev issue.

@heet434 heet434 requested a review from hugocostadev July 2, 2024 17:00
Copy link
Contributor

dionisio-bot bot commented Jul 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@hugocostadev hugocostadev requested a review from a team as a code owner July 4, 2024 15:24
hugocostadev
hugocostadev previously approved these changes Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (77989f5) to head (b3fd334).
Report is 13 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32709      +/-   ##
===========================================
- Coverage    59.40%   59.39%   -0.01%     
===========================================
  Files         2541     2541              
  Lines        63180    63172       -8     
  Branches     14221    14218       -3     
===========================================
- Hits         37530    37524       -6     
+ Misses       22935    22934       -1     
+ Partials      2715     2714       -1     

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
@casalsgh casalsgh added the stat: ready to merge PR tested and approved waiting for merge label Jul 30, 2024
@tassoevan tassoevan added this to the 6.12 milestone Aug 15, 2024
@tassoevan tassoevan added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Aug 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 16, 2024
@tassoevan tassoevan added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Aug 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 19, 2024
@tassoevan tassoevan closed this Aug 19, 2024
@tassoevan tassoevan reopened this Aug 19, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2024
@tassoevan tassoevan changed the title feat: Added Creation Date col in Rooms Table in Admin Panel. feat: Added Creation Date col in Rooms Table in Admin Panel Aug 20, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2024
@ggazzo ggazzo merged commit 0b0d4d8 into RocketChat:develop Aug 21, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
Development

Successfully merging this pull request may close these issues.

7 participants