-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Creation Date col in Rooms Table in Admin Panel #32709
feat: Added Creation Date col in Rooms Table in Admin Panel #32709
Conversation
🦋 Changeset detectedLatest commit: 3099a9b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your contribution...
please, check the CI errors.
Take this PR as reference, we already have a function to format date.
Hi @hugocostadev , I have resolved the typecheck and lint errors, and used the useFormatDate function for formatting the date, but I can't find out as to what exactly is failing the unit test in @rocket.chat/license:testunit . Could you please help me out here? |
Hey @heet434 I'll review it again! Thanks! Related to the unit test, don't worry... it's expected, we are going to fix this internally |
@hugocostadev Thank you! I'll add the commits that resolve the prev issue. |
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32709 +/- ##
===========================================
- Coverage 59.40% 59.39% -0.01%
===========================================
Files 2541 2541
Lines 63180 63172 -8
Branches 14221 14218 -3
===========================================
- Hits 37530 37524 -6
+ Misses 22935 22934 -1
+ Partials 2715 2714 -1 |
Proposed changes (including videos or screenshots)
Added a column that displays the room creation date.
Also added a ts field to retrieve the creation date from the database.
Issue(s)
Here's the link: RocketChat/feature-requests#893
Steps to test or reproduce
Open the Rooms section in Admin Panel. Need for a creation date column there.
Further comments
https://rocketchat.atlassian.net/browse/CONN-293