Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Copy new EE test license from CI to unit tests #32711

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Jul 2, 2024

Proposed changes (including videos or screenshots)

Copy the new EE test license from CI to the licnese package unit tests

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 2, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: d8268e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the title chore: Copy new EE test license from CI to unit tests test: Copy new EE test license from CI to unit tests Jul 2, 2024
@ggazzo
Copy link
Member

ggazzo commented Jul 2, 2024

What about using the env var and the hardcoded one as fallback?

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (7a57f34) to head (d8268e7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32711   +/-   ##
========================================
  Coverage    56.71%   56.72%           
========================================
  Files         2498     2498           
  Lines        55385    55395   +10     
  Branches     11455    11459    +4     
========================================
+ Hits         31412    31422   +10     
+ Misses       21267    21263    -4     
- Partials      2706     2710    +4     
Flag Coverage Δ
e2e 56.48% <ø> (+<0.01%) ⬆️
e2e-api 41.36% <ø> (+0.03%) ⬆️
unit 71.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert
Copy link
Member Author

d-gubert commented Jul 2, 2024

What about using the env var and the hardcoded one as fallback?

did

rodrigok
rodrigok previously approved these changes Jul 2, 2024
@d-gubert d-gubert marked this pull request as ready for review July 2, 2024 20:13
@d-gubert d-gubert requested a review from a team as a code owner July 2, 2024 20:13
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jul 2, 2024
@d-gubert d-gubert added this to the 6.10 milestone Jul 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 2, 2024
@ggazzo ggazzo merged commit eb5f93c into develop Jul 2, 2024
50 checks passed
@ggazzo ggazzo deleted the ci/ee-license-unit-test branch July 2, 2024 21:31
Copy link
Contributor

dionisio-bot bot commented Jul 18, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-6.9.4-32711
git cherry-pick eb5f93c8dc16eba7682381dbbb7b0dd458ad6903
// solve the conflict
git push

after that just run /backport 6.9.4 again

@matheusbsilva137
Copy link
Member

/backport 6.9.4

Copy link
Contributor

dionisio-bot bot commented Jul 18, 2024

Pull request #32835 added to Project: "Patch 6.9.4"

sampaiodiego pushed a commit that referenced this pull request Jul 23, 2024
@sampaiodiego
Copy link
Member

/backport 6.8.4

Copy link
Contributor

dionisio-bot bot commented Jul 23, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-6.8.4-32711
git cherry-pick eb5f93c8dc16eba7682381dbbb7b0dd458ad6903
// solve the conflict
git push

after that just run /backport 6.8.4 again

@ggazzo
Copy link
Member

ggazzo commented Oct 23, 2024

/backport 6.4.10

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Pull request #33716 added to Project: "Patch 6.4.10"

@julio-cfa
Copy link
Member

/backport 6.2.13

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-6.2.13-32711
git cherry-pick eb5f93c8dc16eba7682381dbbb7b0dd458ad6903
// solve the conflict
git push

after that just run /backport 6.2.13 again

@julio-cfa
Copy link
Member

/backport 6.2.13

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Pull request #33751 added to Project: "Patch 6.2.13"

@julio-cfa
Copy link
Member

/backport 6.1.9

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-6.1.9-32711
git cherry-pick eb5f93c8dc16eba7682381dbbb7b0dd458ad6903
// solve the conflict
git push

after that just run /backport 6.1.9 again

@julio-cfa
Copy link
Member

/backport 6.1.9

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Pull request #33753 added to Project: "Patch 6.1.9"

@julio-cfa
Copy link
Member

/backport 6.0.9

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-6.0.9-32711
git cherry-pick eb5f93c8dc16eba7682381dbbb7b0dd458ad6903
// solve the conflict
git push

after that just run /backport 6.0.9 again

@julio-cfa
Copy link
Member

/backport 6.0.9

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Pull request #33755 added to Project: "Patch 6.0.9"

@julio-cfa
Copy link
Member

/backport 5.4.11

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-5.4.11-32711
git cherry-pick eb5f93c8dc16eba7682381dbbb7b0dd458ad6903
// solve the conflict
git push

after that just run /backport 5.4.11 again

@julio-cfa
Copy link
Member

/backport 5.4.11

Copy link
Contributor

dionisio-bot bot commented Oct 24, 2024

Pull request #33758 added to Project: "Patch 5.4.11"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants