-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replicate IPreRoomUserLeave and IPostRoomUserLeave event in meteor method and add removedBy to IRoomUserLeaveContext #32724
Conversation
🦋 Changeset detectedLatest commit: 0cfa318 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32724 +/- ##
===========================================
- Coverage 55.53% 55.49% -0.04%
===========================================
Files 2632 2632
Lines 57175 57174 -1
Branches 11842 11841 -1
===========================================
- Hits 31751 31728 -23
- Misses 22737 22759 +22
Partials 2687 2687
Flags with carried forward coverage won't be shown. Click here to find out more. |
This doesn't strictly require the PR on the Apps-Engine side, it will trigger the event in the new place and send the new context, even if the app won't get to see the info yet. We can treat those as separate (it does not need to wait for the new alpha version of the apps-engine and then update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missing the change set
Proposed changes (including videos or screenshots)
Issue(s)
CORE-498
Depends on RocketChat/Rocket.Chat.Apps-engine#779
Steps to test or reproduce
Further comments