Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replicate IPreRoomUserLeave and IPostRoomUserLeave event in meteor method and add removedBy to IRoomUserLeaveContext #32724

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jul 4, 2024

Proposed changes (including videos or screenshots)

Issue(s)

CORE-498
Depends on RocketChat/Rocket.Chat.Apps-engine#779

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: 0cfa318

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 4, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.49%. Comparing base (25da528) to head (0cfa318).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32724      +/-   ##
===========================================
- Coverage    55.53%   55.49%   -0.04%     
===========================================
  Files         2632     2632              
  Lines        57175    57174       -1     
  Branches     11842    11841       -1     
===========================================
- Hits         31751    31728      -23     
- Misses       22737    22759      +22     
  Partials      2687     2687              
Flag Coverage Δ
e2e 54.24% <ø> (-0.07%) ⬇️
unit 72.05% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review July 9, 2024 23:44
@d-gubert d-gubert requested review from a team as code owners July 9, 2024 23:44
d-gubert
d-gubert previously approved these changes Jul 10, 2024
@d-gubert
Copy link
Member

This doesn't strictly require the PR on the Apps-Engine side, it will trigger the event in the new place and send the new context, even if the app won't get to see the info yet. We can treat those as separate (it does not need to wait for the new alpha version of the apps-engine and then update)

@gabriellsh gabriellsh added this to the 6.11 milestone Jul 11, 2024
@d-gubert d-gubert changed the title chore: Replicate IPreRoomUserLeave and IPostRoomUserLeave event in meteor method and added removedBy to IRoomUserLeaveContext feat: replicate IPreRoomUserLeave and IPostRoomUserLeave event in meteor method and add removedBy to IRoomUserLeaveContext Jul 11, 2024
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing the change set

@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Jul 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 15, 2024
@kodiakhq kodiakhq bot merged commit d0bedf7 into develop Jul 16, 2024
46 checks passed
@kodiakhq kodiakhq bot deleted the extendRoomUserLeaveContext branch July 16, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants