Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Livechat): fix registerguest flaky #32728

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jul 5, 2024

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (b0f182e) to head (044db7e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32728      +/-   ##
===========================================
+ Coverage    56.82%   56.86%   +0.03%     
===========================================
  Files         2495     2498       +3     
  Lines        55295    55335      +40     
  Branches     11402    11411       +9     
===========================================
+ Hits         31421    31464      +43     
+ Misses       21173    21172       -1     
+ Partials      2701     2699       -2     
Flag Coverage Δ
e2e 56.50% <ø> (+0.03%) ⬆️
unit 72.57% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

dionisio-bot bot commented Jul 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 5, 2024

⚠️ No Changeset found

Latest commit: 044db7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 8, 2024 13:43
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 8, 2024 13:43
@ggazzo ggazzo merged commit 811f305 into develop Jul 9, 2024
48 checks passed
@ggazzo ggazzo deleted the flaky-register-guest branch July 9, 2024 19:47
@ggazzo ggazzo added this to the 6.11 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants