Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update contact endpoint #32729

Merged
merged 90 commits into from
Sep 3, 2024
Merged

feat: update contact endpoint #32729

merged 90 commits into from
Sep 3, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jul 5, 2024

Proposed changes (including videos or screenshots)

Implements the endpoint to update contact.
When a contact is updated, the property unknown is set to true.

[POST] api/v1/omnichannel/contacts.update
request example:

{
	"contactId": "668830239ac5cb4b15229d6d"
	"name": "Contact 1",
	"emails": [
		"[email protected]"
	],
	"phones": [
		"5511999999999"
	],
}

response example:

{
	"contact": {
		"_id": "668830239ac5cb4b15229d6d",
		"name": "Contact 1",
		"emails": [
			"[email protected]"
		],
		"phones": [
			"5511999999999"
		],
		"contactManager": "jnuReT9zctgoNKz7t",
		"customFields": {},
		"unknown": false,
		"_updatedAt": "2024-07-05T17:50:01.581Z",
	},
	"success": true
}

Issue(s)

Steps to test or reproduce

Further comments

SCI-34

@tapiarafael tapiarafael changed the base branch from develop to feat/create-contact-endpoint July 5, 2024 17:54
Copy link
Contributor

dionisio-bot bot commented Jul 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 9ec995d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/livechat Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.34%. Comparing base (304bc6d) to head (9ec995d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32729   +/-   ##
========================================
  Coverage    59.33%   59.34%           
========================================
  Files         2546     2546           
  Lines        63235    63253   +18     
  Branches     14214    14218    +4     
========================================
+ Hits         37521    37536   +15     
- Misses       23014    23015    +1     
- Partials      2700     2702    +2     
Flag Coverage Δ
unit 75.48% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael marked this pull request as ready for review July 5, 2024 19:30
@tapiarafael tapiarafael requested review from a team as code owners July 5, 2024 19:30
@MarcosSpessatto MarcosSpessatto added this to the 7.0 milestone Sep 2, 2024
.changeset/heavy-snails-help.md Outdated Show resolved Hide resolved
packages/rest-typings/src/v1/omnichannel.ts Show resolved Hide resolved
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
MarcosSpessatto
MarcosSpessatto previously approved these changes Sep 2, 2024
@tapiarafael tapiarafael added the stat: QA assured Means it has been tested and approved by a company insider label Sep 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 3, 2024
@kodiakhq kodiakhq bot merged commit 9eaefdc into develop Sep 3, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/update-contact-endpoint branch September 3, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants